Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Oscar #4170 - too low precision in factoring #1640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Oscar #4170 - too low precision in factoring #1640

wants to merge 1 commit into from
+4 −3

Conversation

thofma
Copy link
Owner

@thofma thofma commented Oct 9, 2024

No description provided.

@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024

#1639 without the other commit

@thofma thofma marked this pull request as ready for review October 9, 2024 10:07
@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024

@fieker do you have the condensed example?

@thofma thofma mentioned this pull request Oct 9, 2024
Open
@fieker
Copy link
Collaborator

fieker commented Oct 9, 2024 via email

@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024 •
edited
Loading

The following is hanging for me with this change:

Zx, x = FlintZZ["x"]
k, a = number_field(swinnerton_dyer(3, x))
kt, t = k["t"]
g = swinnerton_dyer(8, x)
length(factor(change_base_ring(k, g))) == 8 # van Hoeij

P.S.: It is an example from the tests test/NfAbs/Elem.jl, which are currently hanging.

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.86%. Comparing base (137e629) to head (1c1764e).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   75.80%   75.86%   +0.05%     
==========================================
  Files         361      361              
  Lines      113700   113701       +1     
==========================================
+ Hits        86192    86259      +67     
+ Misses      27508    27442      -66
Files with missing lines Coverage Δ
src/NumField/NfAbs/Poly.jl 44.41% <100.00%> (ø)
src/NumField/NfAbs/PolyFact.jl 86.40% <100.00%> (+8.80%) ⬆️

... and 32 files with indirect coverage changes

@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024

The NfAbs/Elem.jl test finished, but they took 1700 seconds compared to 230 seconds without the changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thofma @fieker